r101233 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101232‎ | r101233 | r101234 >
Date:23:27, 28 October 2011
Author:awjrichards
Status:resolved (Comments)
Tags:
Comment:
Modified paths:
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/DonationData.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/gateway.adapter.php (modified) (history)

Diff [purge]

Index: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/gateway.adapter.php
@@ -247,7 +247,7 @@
248248 $this->debugarray[] = 'Token MISMATCH';
249249 }
250250
251 - $this->refreshGatewayValueFromSource( 'token' );
 251+ $this->refreshGatewayValueFromSource( 'token' );
252252 return $checkResult;
253253 }
254254
@@ -1285,7 +1285,7 @@
12861286 $utm_source_parts[2] = 'pp';
12871287 $data['utm_source'] = implode( ".", $utm_source_parts );
12881288 $data['gateway'] = 'paypal';
1289 - $data['currency_code'] = $data['currency'];
 1289+ $data['currency_code'] = isset( $data['currency'] ) ? $data['currency'] : 'USD';
12901290
12911291 // Add our response vars to the data object.
12921292 $this->dataObj->addData( $data );
@@ -1302,7 +1302,6 @@
13031303
13041304 protected function getPaypalData() {
13051305 $paypalkeys = array(
1306 - 'gateway',
13071306 'contribution_tracking_id',
13081307 'comment',
13091308 'referrer',
Index: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/DonationData.php
@@ -56,7 +56,7 @@
5757 'card_type' => $wgRequest->getText( 'card_type' ),
5858 'expiration' => $wgRequest->getText( 'mos' ) . substr( $wgRequest->getText( 'year' ), 2, 2 ),
5959 'cvv' => $wgRequest->getText( 'cvv' ),
60 - 'currency' => $wgRequest->getText( 'currency_code' ),
 60+ 'currency' => $wgRequest->getText( 'currency_code', 'USD' ),
6161 'payment_method' => $wgRequest->getText( 'payment_method' ),
6262 'payment_submethod' => $wgRequest->getText( 'payment_submethod', null ), // Used by GlobalCollect for payment types
6363 'issuer_id' => $wgRequest->getText( 'issuer_id' ),
Property changes on: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface
___________________________________________________________________
Modified: svn:mergeinfo
6464 Merged /trunk/extensions/DonationInterface:r101230,101232

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101230Fixes a bug in the paypal redirect, in which gateway was being passed twice w...khorn23:19, 28 October 2011
r101232Defaulting currency to USDawjrichards23:26, 28 October 2011

Comments

#Comment by Khorn (WMF) (talk | contribs)   22:01, 5 November 2011

This was all solved a bit differently in ways that eventually resulted in r102011.

Status & tagging log