r101230 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101229‎ | r101230 | r101231 >
Date:23:19, 28 October 2011
Author:khorn
Status:ok (Comments)
Tags:
Comment:
Fixes a bug in the paypal redirect, in which gateway was being passed twice with two different values, causing the redirect to fail.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php
@@ -247,7 +247,7 @@
248248 $this->debugarray[] = 'Token MISMATCH';
249249 }
250250
251 - $this->refreshGatewayValueFromSource( 'token' );
 251+ $this->refreshGatewayValueFromSource( 'token' );
252252 return $checkResult;
253253 }
254254
@@ -1285,7 +1285,7 @@
12861286 $utm_source_parts[2] = 'pp';
12871287 $data['utm_source'] = implode( ".", $utm_source_parts );
12881288 $data['gateway'] = 'paypal';
1289 - $data['currency_code'] = $data['currency'];
 1289+ $data['currency_code'] = isset( $data['currency'] ) ? $data['currency'] : '';
12901290
12911291 // Add our response vars to the data object.
12921292 $this->dataObj->addData( $data );
@@ -1302,7 +1302,6 @@
13031303
13041304 protected function getPaypalData() {
13051305 $paypalkeys = array(
1306 - 'gateway',
13071306 'contribution_tracking_id',
13081307 'comment',
13091308 'referrer',

Follow-up revisions

RevisionCommit summaryAuthorDate
r101233MFT r101230, r101232awjrichards23:27, 28 October 2011

Comments

#Comment by Awjrichards (talk | contribs)   23:26, 28 October 2011
$data['currency_code'] = isset( $data['currency'] ) ? $data['currency'] : '';

Should default to USD. Fixed in r101232.

Status & tagging log