r101229 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101228‎ | r101229 | r101230 >
Date:23:02, 28 October 2011
Author:churchofemacs
Status:ok (Comments)
Tags:
Comment:
Disable proxy for local URLs instead of using a local proxy (which might not always exist). In r61357 a comment "Not sure this makes any sense." was removed. Indeed, that comment seems to have been right :)
Modified paths:
  • /trunk/phase3/includes/HttpFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HttpFunctions.php
——@@ -278,7 +278,7 @@
279279 }
280280
281281 if ( Http::isLocalURL( $this->url ) ) {
282 - $this->proxy = 'http://localhost:80/';
 282+ $this->proxy = '';
283283 } elseif ( $wgHTTPProxy ) {
284284 $this->proxy = $wgHTTPProxy ;
285285 } elseif ( getenv( "http_proxy" ) ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61357Follow up 61352, address TimStarling's comments.mah07:50, 22 January 2010

Comments

#Comment by Church of emacs (talk | contribs)   11:21, 8 November 2011

Please note that the original code might stem from a local requirement of Wikimedia's setup. Before this goes live, it should perhaps be reviewed by a Sysadmin.

Status & tagging log