r101175 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101174‎ | r101175 | r101176 >
Date:19:13, 28 October 2011
Author:preilly
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/MobileFrontend/javascripts/opensearch.js (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/MobileFrontend/stylesheets/common.css (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/MobileFrontend/views/layout/application.html.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/MobileFrontend/javascripts/opensearch.js
@@ -74,6 +74,9 @@
7575 var rel = i + 1;
7676 section.value = section.value.replace( /^(?:\/\/|[^\/]+)*\//, '/' );
7777 html = html + "<div class=\"suggestions-result\" rel=\"" + rel + "\" title=\"" + section.label + "\"><a href='" + section.value + "'>" + section.label + "</a></div>";
 78+ if ( i < ( sections.length - 1 ) ) {
 79+ html = html + '<hr />';
 80+ }
7881 }
7982 html = html + '</div>';
8083 results.innerHTML = html;
Index: branches/wmf/1.18wmf1/extensions/MobileFrontend/stylesheets/common.css
@@ -16,7 +16,7 @@
1717 }
1818
1919 .suggestions-results {
20 - font-size: 1em;
 20+ font-size: 1.2em;
2121 cursor: pointer;
2222 }
2323
Index: branches/wmf/1.18wmf1/extensions/MobileFrontend/views/layout/application.html.php
@@ -18,7 +18,7 @@
1919 $endScriptTag = '"></script>';
2020 $javaScriptPath = $wgExtensionAssetsPath . '/MobileFrontend/javascripts/';
2121
22 -$openSearchScript = ( self::$isBetaGroupMember ) ? $startScriptTag . $javaScriptPath . 'opensearch.js?version=10282011120715' . $endScriptTag : '';
 22+$openSearchScript = ( self::$isBetaGroupMember ) ? $startScriptTag . $javaScriptPath . 'opensearch.js?version=10282011120815' . $endScriptTag : '';
2323
2424 $applicationHtml = <<<EOT
2525 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
@@ -27,7 +27,7 @@
2828 <head>
2929 <title>{$htmlTitle}</title>
3030 <meta http-equiv="content-type" content="application/xhtml+xml; charset=utf-8" />
31 - <link href='{$wgExtensionAssetsPath}/MobileFrontend/stylesheets/common.css?version=10282011120715' media='all' rel='Stylesheet' type='text/css' />
 31+ <link href='{$wgExtensionAssetsPath}/MobileFrontend/stylesheets/common.css?version=10282011120815' media='all' rel='Stylesheet' type='text/css' />
3232 <link href='{$wgExtensionAssetsPath}/MobileFrontend/stylesheets/{$cssFileName}.css?version=10202011120715' media='all' rel='Stylesheet' type='text/css' />
3333 <meta name="ROBOTS" content="NOINDEX, NOFOLLOW" />
3434 <meta name = "viewport" content = "width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=0" />

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101173increase font size of results and add hr between thempreilly19:09, 28 October 2011

Status & tagging log