r101139 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101138‎ | r101139 | r101140 >
Date:15:28, 28 October 2011
Author:johnduhart
Status:deferred
Tags:
Comment:
Followup r101137, removed some stuff that snuck in and addedPHP doc
Modified paths:
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php
@@ -63,6 +63,10 @@
6464 return array( $status, $user );
6565 }
6666
 67+ /**
 68+ * @param $user User
 69+ * @return String
 70+ */
6771 public static function getStatus( $user ) {
6872 global $wgOnlineStatusBarDefaultOffline, $wgOnlineStatusBarDefaultOnline;
6973
@@ -150,10 +154,6 @@
151155 return $wgOnlineStatusBarTrackIpUsers;
152156 }
153157
154 - if ( $user->getId() == 0 )
155 - {
156 - return false;
157 - }
158158 // do we track them
159159 return $user->getOption( "OnlineStatusBar_active", $wgOnlineStatusBarDefaultEnabled );
160160 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101137Code improvements and cleanup to OnlineStatusBarjohnduhart15:12, 28 October 2011

Status & tagging log