r101135 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101134‎ | r101135 | r101136 >
Date:14:42, 28 October 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Removed $wgTranslateMessageReview global - it will stay hidden from the ui unless the user has right to use it
Updated readme
Modified paths:
  • /trunk/extensions/Translate/MessageCollection.php (modified) (history)
  • /trunk/extensions/Translate/README (modified) (history)
  • /trunk/extensions/Translate/Translate.php (modified) (history)
  • /trunk/extensions/Translate/TranslateHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/MessageCollection.php
@@ -595,8 +595,7 @@
596596 * @param $dbtype One of DB_* constants.
597597 */
598598 protected function loadReviewInfo( array $keys, $dbtype = DB_SLAVE ) {
599 - global $wgTranslateMessageReview;
600 - if ( $this->dbReviewData !== null || !$wgTranslateMessageReview ) {
 599+ if ( $this->dbReviewData !== null ) {
601600 return;
602601 }
603602
Index: trunk/extensions/Translate/Translate.php
@@ -554,9 +554,6 @@
555555 */
556556 $wgTranslateYamlLibrary = 'spyc';
557557
558 -# ==== Features in development ====
559 -$wgTranslateMessageReview = false;
560 -
561558 /** @cond cli_support */
562559 if ( !defined( 'TRANSLATE_CLI' ) ) {
563560 function STDOUT() { }
Index: trunk/extensions/Translate/TranslateHooks.php
@@ -183,10 +183,7 @@
184184 $updater->addExtensionUpdate( array( 'addTable', 'translate_groupstats', "$dir/translate_groupstats.sql", true ) );
185185 $updater->addExtensionUpdate( array( 'addIndex', 'translate_sections', 'trs_page_order', "$dir/translate_sections-indexchange.sql", true ) );
186186 $updater->addExtensionUpdate( array( 'dropIndex', 'translate_sections', 'trs_page', "$dir/translate_sections-indexchange2.sql", true ) );
187 - global $wgTranslateMessageReview;
188 - if ( $wgTranslateMessageReview ) {
189 - $updater->addExtensionUpdate( array( 'addTable', 'translate_reviews', "$dir/translate_reviews.sql", true ) );
190 - }
 187+ $updater->addExtensionUpdate( array( 'addTable', 'translate_reviews', "$dir/translate_reviews.sql", true ) );
191188
192189 return true;
193190 }
Index: trunk/extensions/Translate/README
@@ -29,6 +29,10 @@
3030 http://translatewiki.net/docs/Translate/html/
3131
3232 == Change log ==
 33+* 2011-10-28
 34+- Message review feature, available to users in translate-proofr group
 35+- Message collections can now have properties and allow filtering on them
 36+ This is still work in progress and is likely to get improvements over time
3337 * 2011-10-14
3438 - New API module: messagetranslations
3539 * 2011-10-12

Status & tagging log