r101003 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101002‎ | r101003 | r101004 >
Date:17:19, 27 October 2011
Author:catrope
Status:deferred
Tags:
Comment:
Followup r100992: pass the regex directly rather than wrapping it in a function. I did the latter for debugging purposes and forgot to undo it before committing
Modified paths:
  • /trunk/parsers/wikidom/tests/hype/es.DocumentModel.test.js (modified) (history)

Diff [purge]

Index: trunk/parsers/wikidom/tests/hype/es.DocumentModel.test.js
@@ -572,8 +572,7 @@
573573 [ { 'type': 'paragraph' }, 'f', 'o', 'o', { 'type': '/paragraph' } ]
574574 );
575575 },
576 - function ( e ) {
577 - return /^Offset -1 out of bounds/.test( e ); },
 576+ /^Offset -1 out of bounds/,
578577 'prepareInsertion throws exception for negative offset'
579578 );
580579
@@ -585,8 +584,7 @@
586585 [ { 'type': 'paragraph' }, 'f', 'o', 'o', { 'type': '/paragraph' } ]
587586 );
588587 },
589 - function ( e ) {
590 - return /^Offset 29 out of bounds/.test( e ); },
 588+ /^Offset 29 out of bounds/,
591589 'prepareInsertion throws exception for offset past the end'
592590 );
593591 } );

Sign-offs

UserFlagDate
Nikerabbitinspected06:23, 28 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100992prepareInsertion: Add test cases for on-the-edge and past-the-edge offsets, a...catrope16:03, 27 October 2011

Status & tagging log