r100983 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100982‎ | r100983 | r100984 >
Date:15:25, 27 October 2011
Author:platonides
Status:ok
Tags:
Comment:
Change the name back to dumpHook (r96336). That makes obvious that the use of var_dump is intended.
Modified paths:
  • /trunk/phase3/tests/parser/parserTestsParserHook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/parser/parserTestsParserHook.php
@@ -28,12 +28,12 @@
2929 class ParserTestParserHook {
3030
3131 static function setup( &$parser ) {
32 - $parser->setHook( 'tag', array( __CLASS__, 'tagHook' ) );
 32+ $parser->setHook( 'tag', array( __CLASS__, 'dumpHook' ) );
3333 $parser->setHook( 'statictag', array( __CLASS__, 'staticTagHook' ) );
3434 return true;
3535 }
3636
37 - static function tagHook( $in, $argv ) {
 37+ static function dumpHook( $in, $argv ) {
3838 ob_start();
3939 var_dump(
4040 $in,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96336Merge ParserTestStaticParserHook into ParserTestParserHook since they practic...demon14:46, 6 September 2011

Status & tagging log