r100979 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100978‎ | r100979 | r100980 >
Date:14:51, 27 October 2011
Author:petrb
Status:deferred
Tags:
Comment:
moved to css all stuff I could
Modified paths:
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php (modified) (history)
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.css (modified) (history)
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php
@@ -21,8 +21,8 @@
2222 global $wgOnlineStatusBarColor, $wgOnlineStatusBarY;
2323 $color = $wgOnlineStatusBarColor[$mode];
2424 return <<<HTML
25 -<div style="right:0px; margin-top:-10px;" class="metadata topiconstatus" id="status-top">
26 -<div style="border: 0px solid black; background: transparent; float: right; position: relative; top: {$wgOnlineStatusBarY}px; padding: 5px">
 25+<div class="onlinebar metadata topiconstatus" id="status-top">
 26+<div class="statusbaricon">
2727 $text</div></div>
2828 HTML;
2929 }
Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.php
@@ -68,9 +68,6 @@
6969 $wgOnlineStatusBarDefaultEnabled = false;
7070 // how long to wait until user is considered as offline
7171 $wgOnlineStatusBar_LogoutTime = 3600;
72 -// position of status bar
73 -// change to -35 to have it in title bar
74 -$wgOnlineStatusBarY = "0";
7572
7673 $wgHooks['LoadExtensionSchemaUpdates'][] = 'wfOnlineStatusBar_CkSchema';
7774 function wfOnlineStatusBar_CkSchema( $updater = null ) {
Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.css
@@ -3,9 +3,22 @@
44 where topicon isn't defined
55 */
66 div.topiconstatus {
7 - position: absolute;
8 - top: -2em;
9 - margin-right: -10px;
10 - display: block !important;
 7+ position: absolute;
 8+ top: -2em;
 9+ margin-right: -10px;
 10+ display: block !important;
1111 }
1212
 13+div.statusbaricon {
 14+ border: 0px solid black;
 15+ background: transparent;
 16+ float: right;
 17+ position: relative;
 18+ top: 0px;
 19+ padding: 5px;
 20+}
 21+
 22+div.onlinebar {
 23+ right:0px;
 24+ margin-top:-10px;
 25+}

Status & tagging log