r100973 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100972‎ | r100973 | r100974 >
Date:13:26, 27 October 2011
Author:petrb
Status:deferred
Tags:
Comment:
removed tolower, per comments on previous rev
Modified paths:
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php
@@ -71,7 +71,7 @@
7272 if ( OnlineStatusBar::GetStatus( $wgUser->getName() ) != $wgOnlineStatusBarDefaultOnline ) {
7373 $dbw = wfGetDB( DB_MASTER );
7474 $row = array(
75 - 'username' => strtolower( $wgUser->getName() ),
 75+ 'username' => $wgUser->getName(),
7676 'timestamp' => $dbw->timestamp( wfTimestamp() ),
7777 );
7878 $dbw->insert( 'online_status', $row, __METHOD__, 'DELAYED' );
@@ -101,7 +101,7 @@
102102 $dbw->update(
103103 'online_status',
104104 array( 'timestamp' => $dbw->timestamp( wfTimestamp() ) ),
105 - array( 'username' => strtolower( $wgUser->getID() ) ),
 105+ array( 'username' => $wgUser->getID() ),
106106 __METHOD__
107107 );
108108
@@ -149,7 +149,7 @@
150150 // something is wrong
151151 return $wgOnlineStatusBarDefaultOffline;
152152 }
153 - $result = $dbw->selectField( 'online_status', 'username', array( 'username' => strtolower( $userID ) ),
 153+ $result = $dbw->selectField( 'online_status', 'username', array( 'username' => $userID ),
154154 __METHOD__, array( 'limit 1', 'order by timestamp desc' ) );
155155 if ( $result ) {
156156 $status = $user->getOption( "OnlineStatusBar_status" );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100835user configuration...petrb18:30, 26 October 2011
r100865better way to get page ownerpetrb20:36, 26 October 2011

Status & tagging log