r100968 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r100967‎ | r100968 | r100969 >
Date:12:36, 27 October 2011
Author:mkroetzsch
Status:deferred
Tags:
Comment:
use m_dataitem instead of getDataItem internally (the latter may return SMWDIError objects to report errors, but internal calls usually want the m_dataitem SMWDIProperty object even if there are errors)
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Property.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Property.php
——@@ -265,7 +265,7 @@
266266 * Create special highlighting for hinting at special properties.
267267 */
268268 protected function highlightText( $text ) {
269 - if ( $this->getDataItem()->isUserDefined() ) {
 269+ if ( $this->m_dataitem->isUserDefined() ) {
270270 return $text;
271271 } else {
272272 SMWOutputs::requireResource( 'ext.smw.tooltips' );