r100938 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100937‎ | r100938 | r100939 >
Date:02:54, 27 October 2011
Author:kaldari
Status:ok
Tags:
Comment:
follow-up to r100935, the Html::element method is self-closing
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/GatewayForm.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/GatewayForm.php
@@ -355,7 +355,7 @@
356356 if ( !empty( $results['errors'] ) ) {
357357 $wgOut->addHTML( HTML::openElement( 'ul' ) );
358358 foreach ( $results['errors'] as $code => $value ) {
359 - $wgOut->addHTML( HTML::element('li', null, "Error $code: $value" ) . HTML::closeElement( 'li' ) );
 359+ $wgOut->addHTML( HTML::element('li', null, "Error $code: $value" ) );
360360 }
361361 $wgOut->addHTML( HTML::closeElement( 'ul' ) );
362362 }
@@ -364,13 +364,13 @@
365365 $wgOut->addHTML( HTML::openElement( 'ul' ) );
366366 foreach ( $results['data'] as $key => $value ) {
367367 if ( is_array( $value ) ) {
368 - $wgOut->addHTML( HTML::element('li', null, $key ) . HTML::openElement( 'ul' ) );
 368+ $wgOut->addHTML( HTML::openElement('li', null, $key ) . HTML::openElement( 'ul' ) );
369369 foreach ( $value as $key2 => $val2 ) {
370 - $wgOut->addHTML( HTML::element('li', null, "$key2: $val2" ) . HTML::closeElement( 'li' ) );
 370+ $wgOut->addHTML( HTML::element('li', null, "$key2: $val2" ) );
371371 }
372372 $wgOut->addHTML( HTML::closeElement( 'ul' ) . HTML::closeElement( 'li' ) );
373373 } else {
374 - $wgOut->addHTML( HTML::element('li', null, "$key: $value" ) . HTML::closeElement( 'li' ) );
 374+ $wgOut->addHTML( HTML::element('li', null, "$key: $value" ) );
375375 }
376376 }
377377 $wgOut->addHTML( HTML::closeElement( 'ul' ) );
@@ -380,7 +380,7 @@
381381 if ( array_key_exists( 'Donor', $_SESSION ) ) {
382382 $wgOut->addHTML( "Session Donor Vars:" . HTML::openElement( 'ul' ));
383383 foreach ( $_SESSION['Donor'] as $key => $val ) {
384 - $wgOut->addHTML( HTML::element('li', null, "$key: $val" ) . HTML::closeElement( 'li' ) );
 384+ $wgOut->addHTML( HTML::element('li', null, "$key: $val" ) );
385385 }
386386 $wgOut->addHTML( HTML::closeElement( 'ul' ) );
387387 } else {
@@ -390,7 +390,7 @@
391391 if ( is_array( $this->adapter->debugarray ) ) {
392392 $wgOut->addHTML( "Debug Array:" . HTML::openElement( 'ul' ) );
393393 foreach ( $this->adapter->debugarray as $val ) {
394 - $wgOut->addHTML( HTML::element('li', null, $val ) . HTML::closeElement( 'li' ) );
 394+ $wgOut->addHTML( HTML::element('li', null, $val ) );
395395 }
396396 $wgOut->addHTML( HTML::closeElement( 'ul' ) );
397397 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100935Addresses a couple fixme-type comments from r98202.khorn01:51, 27 October 2011

Status & tagging log