r100936 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100935‎ | r100936 | r100937 >
Date:02:31, 27 October 2011
Author:kaldari
Status:ok
Tags:fundraising 
Comment:
follow-up to r100896, just removing an unnecessary !empty and fixing a !
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php
@@ -427,7 +427,7 @@
428428
429429 if ( empty( $this->transactions ) ||
430430 !array_key_exists( $transaction, $this->transactions ) ||
431 - ! array_key_exists( 'request', $this->transactions[$transaction] ) ) {
 431+ !array_key_exists( 'request', $this->transactions[$transaction] ) ) {
432432
433433 $msg = self::getGatewayName() . ": $transaction request structure is empty! No transaction can be constructed.";
434434 self::log( $msg, LOG_CRIT );
@@ -1371,7 +1371,7 @@
13721372 }
13731373
13741374 public function getTransactionAllResults() {
1375 - if ( !empty( $this->transaction_results ) && is_array( $this->transaction_results ) ) {
 1375+ if ( $this->transaction_results && is_array( $this->transaction_results ) ) {
13761376 return $this->transaction_results;
13771377 } else {
13781378 return false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100896Mostly concerned with splitting currentTransaction into getCurrentTransaction...khorn23:06, 26 October 2011

Status & tagging log