r100930 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100929‎ | r100930 | r100931 >
Date:01:32, 27 October 2011
Author:yaron
Status:deferred
Tags:
Comment:
Fix to r99691 - correct check for empty input type
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormField.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormField.php
@@ -272,11 +272,12 @@
273273 }
274274 if ( ! $part_of_multiple ) { $text .= "| "; }
275275 $text .= "{{{field|" . $this->template_field->getFieldName();
276 - // TODO - why is there an input type field in both the form field and the template
277 - // field? One of them should probably be removed.
 276+ // TODO - why is there an input type field in both the form
 277+ // field and the template field? One of them should probably
 278+ // be removed.
278279 if ( $this->mIsHidden ) {
279280 $text .= "|hidden";
280 - } elseif ( !is_null( $this->getInputType() ) ) {
 281+ } elseif ( $this->getInputType() != '' ) {
281282 $text .= "|input type=" . $this->getInputType();
282283 } elseif ( $this->template_field->getInputType() != '' ) {
283284 $text .= "|input type=" . $this->template_field->getInputType();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99691Bug fix for displaying input typeyaron16:34, 13 October 2011