r100908 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100907‎ | r100908 | r100909 >
Date:23:43, 26 October 2011
Author:awjrichards
Status:ok
Tags:fundraising 
Comment:
Fixing form_placeholders.js to make sure fname and lname are not set to 'First name' and 'Last name' rather than and
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/form_placeholders.js (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/form_placeholders.js
@@ -26,10 +26,10 @@
2727 }
2828 }
2929
30 - if (document.getElementById('fname').value == '$first') {
 30+ if (document.getElementById('fname').value == mw.msg( 'donate_interface-donor-fname' )) {
3131 output += mw.msg( 'donate_interface-error-msg-js' ) + ' first name.\r\n';
3232 }
33 - if (document.getElementById('lname').value == '$last') {
 33+ if (document.getElementById('lname').value == mw.msg( 'donate_interface-donor-lname' )) {
3434 output += mw.msg( 'donate_interface-error-msg-js' ) + ' last name.\r\n';
3535 }
3636 var countryField = document.getElementById( 'country' );

Status & tagging log