r100864 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100863‎ | r100864 | r100865 >
Date:20:31, 26 October 2011
Author:mah
Status:ok (Comments)
Tags:
Comment:
Apply patch from Bug 29580 - “allow placeholder for inputbox” from Grunny
Modified paths:
  • /trunk/extensions/InputBox/InputBox.classes.php (modified) (history)

Diff [purge]

Index: trunk/extensions/InputBox/InputBox.classes.php
@@ -22,6 +22,7 @@
2323 private $mPage = '';
2424 private $mBR = 'yes';
2525 private $mDefaultText = '';
 26+ private $mPlaceholderText = '';
2627 private $mBGColor = 'transparent';
2728 private $mButtonLabel = '';
2829 private $mSearchButtonLabel = '';
@@ -103,6 +104,7 @@
104105 'name' => 'search',
105106 'type' => $this->mHidden ? 'hidden' : 'text',
106107 'value' => $this->mDefaultText,
 108+ 'placeholder' => $this->mPlaceholderText,
107109 'size' => $this->mWidth,
108110 )
109111 );
@@ -391,6 +393,7 @@
392394 'name' => 'title',
393395 'class' => 'createboxInput',
394396 'value' => $this->mDefaultText,
 397+ 'placeholder' => $this->mPlaceholderText,
395398 'size' => $this->mWidth
396399 )
397400 );
@@ -463,6 +466,7 @@
464467 'name' => 'preloadtitle',
465468 'class' => 'commentboxInput',
466469 'value' => $this->mDefaultText,
 470+ 'placeholder' => $this->mPlaceholderText,
467471 'size' => $this->mWidth
468472 )
469473 );
@@ -525,6 +529,7 @@
526530 'minor' => 'mMinor',
527531 'break' => 'mBR',
528532 'default' => 'mDefaultText',
 533+ 'placeholder' => 'mPlaceholderText',
529534 'bgcolor' => 'mBGColor',
530535 'buttonlabel' => 'mButtonLabel',
531536 'searchbuttonlabel' => 'mSearchButtonLabel',

Sign-offs

UserFlagDate
Nikerabbitinspected06:27, 27 October 2011

Comments

#Comment by Hashar (talk | contribs)   14:59, 6 December 2011

Status & tagging log