r100860 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100859‎ | r100860 | r100861 >
Date:19:48, 26 October 2011
Author:platonides
Status:ok (Comments)
Tags:
Comment:
More Solaris sh compatibility, remove the temporary folder on exit
Modified paths:
  • /trunk/tools/justMessages/update-msgs.sh (modified) (history)

Diff [purge]

Index: trunk/tools/justMessages/update-msgs.sh
@@ -6,7 +6,9 @@
77 FOLDER="$1"
88 fi
99
10 -if ! which "$JUSTMESSAGES" 2> /dev/null 1>&2; then
 10+if which "$JUSTMESSAGES" 2> /dev/null 1>&2; then
 11+ : # Solaris sh doesn't lile if ! <command> (!: not found)
 12+else
1113 DIRNAME=`dirname $0`
1214 if [ -z "$DIRNAME" ]; then
1315 DIRNAME="."
@@ -25,5 +27,6 @@
2628 find "$TEMP" -name "*.php" -exec "$JUSTMESSAGES" \{\} +
2729 touch "$TEMP/.svn/lock"
2830 rsync -a --delete "$TEMP"/ "$FOLDER"
 31+rm -rf "$TEMP"
2932 # $LOCKFILE removed on exit
3033

Comments

#Comment by 😂 (talk | contribs)   15:06, 16 December 2011

Typo in your comment (lile -> like). Otherwise looks ok.

#Comment by 😂 (talk | contribs)   15:08, 16 December 2011

Hadn't looked at r102013 yet, nevermind.

Status & tagging log