r100855 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100854‎ | r100855 | r100856 >
Date:19:34, 26 October 2011
Author:catrope
Status:ok
Tags:
Comment:
[RL2] Make the checkbox with the empty label on the shared preferences tab go away
Modified paths:
  • /branches/RL2/extensions/Gadgets/Gadgets.hooks.php (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/Gadgets.hooks.php
@@ -298,8 +298,8 @@
299299 array(
300300 'type' => 'multiselect',
301301 //'options' => array(), // TODO: Maybe fill in stuff anyway? The backend may need that
302 - 'options' => array_combine( explode( '|', $GLOBALS['wgRequest']->getVal( 'ryanscrewedchadover' ) ),
303 - explode( '|', $GLOBALS['wgRequest']->getVal( 'ryanscrewedchadover2' ) ) ),
 302+ 'options' => $GLOBALS['wgRequest']->getCheck( 'ryanscrewedchadover' ) ? array_combine( explode( '|', $GLOBALS['wgRequest']->getVal( 'ryanscrewedchadover' ) ),
 303+ explode( '|', $GLOBALS['wgRequest']->getVal( 'ryanscrewedchadover2' ) ) ) : array(),
304304 'section' => 'gadgets-shared',
305305 'label' => ' ',
306306 'prefix' => 'gadget-',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100853[RL2] Make the JS that build the shared gadgets preferences form will now sav...catrope19:32, 26 October 2011

Status & tagging log