r100825 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100824‎ | r100825 | r100826 >
Date:16:29, 26 October 2011
Author:jpostlethwaite
Status:deferred
Tags:fundraising 
Comment:
Updating unit test AllTests for GlobalCollect Adapter. Updated @since tags, removed old comments.
Modified paths:
  • /trunk/extensions/DonationInterface/tests/Adapter/GlobalCollect/AllTests.php (modified) (history)
  • /trunk/extensions/DonationInterface/tests/Adapter/GlobalCollect/GlobalCollectTestCase.php (modified) (history)
  • /trunk/extensions/DonationInterface/tests/Adapter/GlobalCollect/RealTimeBankTransferEnetsTestCase.php (modified) (history)
  • /trunk/extensions/DonationInterface/tests/Adapter/GlobalCollect/RealTimeBankTransferEpsTestCase.php (modified) (history)
  • /trunk/extensions/DonationInterface/tests/Adapter/GlobalCollect/RealTimeBankTransferIdealTestCase.php (modified) (history)
  • /trunk/extensions/DonationInterface/tests/Adapter/GlobalCollect/RealTimeBankTransferNordeaSweedenTestCase.php (modified) (history)
  • /trunk/extensions/DonationInterface/tests/Adapter/GlobalCollect/RealTimeBankTransferSofortuberweisungTestCase.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/tests/Adapter/GlobalCollect/AllTests.php
@@ -20,12 +20,41 @@
2121 */
2222
2323 /**
24 - * @see DonationInterface_Adapter_ServerTestCase
 24+ * @see DonationInterface_Adapter_GlobalCollect_GlobalCollectTestCase
2525 */
26 -require_once dirname( __FILE__ ) . DIRECTORY_SEPARATOR . 'BankTransferTestCase.php';
2726 require_once dirname( __FILE__ ) . DIRECTORY_SEPARATOR . 'GlobalCollectTestCase.php';
2827
2928 /**
 29+ * @see DonationInterface_Adapter_GlobalCollect_GlobalCollectTestCase
 30+ */
 31+require_once dirname( __FILE__ ) . DIRECTORY_SEPARATOR . 'BankTransferTestCase.php';
 32+
 33+/**
 34+ * @see DonationInterface_Adapter_GlobalCollect_RealTimeBankTransferEnetsTestCase
 35+ */
 36+require_once dirname( __FILE__ ) . DIRECTORY_SEPARATOR . 'RealTimeBankTransferEnetsTestCase.php';
 37+
 38+/**
 39+ * @see DonationInterface_Adapter_GlobalCollect_RealTimeBankTransferEpsTestCase
 40+ */
 41+require_once dirname( __FILE__ ) . DIRECTORY_SEPARATOR . 'RealTimeBankTransferEpsTestCase.php';
 42+
 43+/**
 44+ * @see DonationInterface_Adapter_GlobalCollect_RealTimeBankTransferIdealTestCase
 45+ */
 46+require_once dirname( __FILE__ ) . DIRECTORY_SEPARATOR . 'RealTimeBankTransferIdealTestCase.php';
 47+
 48+/**
 49+ * @see DonationInterface_Adapter_GlobalCollect_RealTimeBankTransferNordeaSweedenTestCase
 50+ */
 51+require_once dirname( __FILE__ ) . DIRECTORY_SEPARATOR . 'RealTimeBankTransferNordeaSweedenTestCase.php';
 52+
 53+/**
 54+ * @see DonationInterface_Adapter_GlobalCollect_RealTimeBankTransferSofortuberweisungTestCase
 55+ */
 56+require_once dirname( __FILE__ ) . DIRECTORY_SEPARATOR . 'RealTimeBankTransferSofortuberweisungTestCase.php';
 57+
 58+/**
3059 * AllTests
3160 */
3261 class DonationInterface_Adapter_GlobalCollect_AllTests
@@ -53,9 +82,29 @@
5483 {
5584 $suite = new PHPUnit_Framework_TestSuite( 'Donation Interface - Adapter Suite' );
5685
57 - $suite->addTestSuite( 'DonationInterface_Adapter_GlobalCollect_BankTransferTestCase' );
 86+ // General adapter tests
5887 $suite->addTestSuite( 'DonationInterface_Adapter_GlobalCollect_GlobalCollectTestCase' );
5988
 89+ // Bank transfer tests
 90+ $suite->addTestSuite( 'DonationInterface_Adapter_GlobalCollect_BankTransferTestCase' );
 91+
 92+ // Real time bank transfer tests
 93+
 94+ // eNets
 95+ $suite->addTestSuite( 'DonationInterface_Adapter_GlobalCollect_RealTimeBankTransferEnetsTestCase' );
 96+
 97+ // eps Online-Überweisung
 98+ $suite->addTestSuite( 'DonationInterface_Adapter_GlobalCollect_RealTimeBankTransferEpsTestCase' );
 99+
 100+ // Ideal
 101+ $suite->addTestSuite( 'DonationInterface_Adapter_GlobalCollect_RealTimeBankTransferIdealTestCase' );
 102+
 103+ // Nordea (Sweeden)
 104+ $suite->addTestSuite( 'DonationInterface_Adapter_GlobalCollect_RealTimeBankTransferNordeaSweedenTestCase' );
 105+
 106+ // eNETS
 107+ $suite->addTestSuite( 'DonationInterface_Adapter_GlobalCollect_RealTimeBankTransferSofortuberweisungTestCase' );
 108+
60109 return $suite;
61110 }
62111 }
Index: trunk/extensions/DonationInterface/tests/Adapter/GlobalCollect/RealTimeBankTransferSofortuberweisungTestCase.php
@@ -14,7 +14,7 @@
1515 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1616 * GNU General Public License for more details.
1717 *
18 - * @since r98249
 18+ * @since r100824
1919 * @author Jeremy Postlethwaite <jpostlethwaite@wikimedia.org>
2020 */
2121
Index: trunk/extensions/DonationInterface/tests/Adapter/GlobalCollect/RealTimeBankTransferEnetsTestCase.php
@@ -14,7 +14,7 @@
1515 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1616 * GNU General Public License for more details.
1717 *
18 - * @since r98249
 18+ * @since r100821
1919 * @author Jeremy Postlethwaite <jpostlethwaite@wikimedia.org>
2020 */
2121
Index: trunk/extensions/DonationInterface/tests/Adapter/GlobalCollect/RealTimeBankTransferIdealTestCase.php
@@ -14,7 +14,7 @@
1515 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1616 * GNU General Public License for more details.
1717 *
18 - * @since r98249
 18+ * @since r100822
1919 * @author Jeremy Postlethwaite <jpostlethwaite@wikimedia.org>
2020 */
2121
Index: trunk/extensions/DonationInterface/tests/Adapter/GlobalCollect/GlobalCollectTestCase.php
@@ -59,7 +59,7 @@
6060 'COUNTRYCODE' => 'country',
6161 'MERCHANTREFERENCE' => 'order_id',
6262 'RETURNURL' => 'returnto',
63 - 'IPADDRESS' => 'user_ip', //TODO: Not sure if this should be OUR ip, or the user's ip. Hurm.
 63+ 'IPADDRESS' => 'user_ip',
6464 'ISSUERID' => 'issuer_id',
6565 'PAYMENTPRODUCTID' => 'payment_product',
6666 'CVV' => 'cvv',
Index: trunk/extensions/DonationInterface/tests/Adapter/GlobalCollect/RealTimeBankTransferNordeaSweedenTestCase.php
@@ -14,7 +14,7 @@
1515 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1616 * GNU General Public License for more details.
1717 *
18 - * @since r98249
 18+ * @since r100823
1919 * @author Jeremy Postlethwaite <jpostlethwaite@wikimedia.org>
2020 */
2121
Index: trunk/extensions/DonationInterface/tests/Adapter/GlobalCollect/RealTimeBankTransferEpsTestCase.php
@@ -14,7 +14,7 @@
1515 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1616 * GNU General Public License for more details.
1717 *
18 - * @since r98249
 18+ * @since r100820
1919 * @author Jeremy Postlethwaite <jpostlethwaite@wikimedia.org>
2020 */
2121

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100819Setup unit test for Bank Transfer.jpostlethwaite16:15, 26 October 2011

Status & tagging log