r100781 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100780‎ | r100781 | r100782 >
Date:04:08, 26 October 2011
Author:khorn
Status:ok
Tags:fundraising 
Comment:
Constructed a couple forms a little too aggressively (Oops).
r100777
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetter3.php (modified) (history)
  • /trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetterCA.php (modified) (history)
  • /trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnPremium.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetterCA.php
@@ -2,7 +2,6 @@
33
44 class Gateway_Form_TwoStepTwoColumnLetterCA extends Gateway_Form_TwoStepTwoColumn {
55 public function __construct( &$gateway, &$form_errors ) {
6 - parent::__construct( $gateway, $form_errors );
76 global $wgScriptPath;
87
98 // set the path to css, before the parent constructor is called, checking to make sure some child class hasn't already set this
Index: trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnPremium.php
@@ -2,7 +2,6 @@
33
44 class Gateway_Form_TwoStepTwoColumnPremium extends Gateway_Form_TwoStepTwoColumn {
55 public function __construct( &$gateway, &$form_errors ) {
6 - parent::__construct( $gateway, $form_errors );
76 global $wgScriptPath;
87
98 // set the path to css, before the parent constructor is called, checking to make sure some child class hasn't already set this
Index: trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetter3.php
@@ -2,7 +2,6 @@
33
44 class Gateway_Form_TwoStepTwoColumnLetter3 extends Gateway_Form_TwoStepTwoColumn {
55 public function __construct( &$gateway, &$form_errors ) {
6 - parent::__construct( $gateway, $form_errors );
76 global $wgExtensionAssetsPath;
87
98 // set the path to css, before the parent constructor is called, checking to make sure some child class hasn't already set this

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100777This commit addresses a couple issues in DonationInterface that turned out to...khorn03:01, 26 October 2011

Status & tagging log