r100771 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100770‎ | r100771 | r100772 >
Date:02:42, 26 October 2011
Author:reedy
Status:deferred
Tags:
Comment:
More OCD

Also </body>
Modified paths:
  • /trunk/tools/subversion/users.php (modified) (history)

Diff [purge]

Index: trunk/tools/subversion/users.php
@@ -7,12 +7,12 @@
88
99 <body>
1010 <h1>Wikimedia Subversion user list</h1>
11 - <table border="1">
12 - <tr>
13 - <th>Username</th>
14 - <th>Real name</th>
15 - <th>Ready for git?</th>
16 - </tr>
 11+ <table border="1">
 12+ <tr>
 13+ <th>Username</th>
 14+ <th>Real name</th>
 15+ <th>Ready for git?</th>
 16+ </tr>
1717 <?php
1818
1919 $time = microtime( true );
@@ -36,21 +36,23 @@
3737 $link = $userInfo['url'] ? "<a href=\"{$userInfo['url']}\">$encUsername</a>" : $encUsername;
3838
3939 $rows[$parts[0]] = <<<EOT
40 -<tr id="$encUsername">
41 -<td>$link</td>
42 -<td>{$userInfo['name']}</td>
43 -<td></td>
44 -<td>$readyForGit</td>
45 -</tr>
 40+ <tr id="$encUsername">
 41+ <td>$link</td>
 42+ <td>{$userInfo['name']}</td>
 43+ <td></td>
 44+ <td>$readyForGit</td>
 45+ </tr>
4646
4747 EOT;
4848 }
4949 ksort( $rows );
50 -echo implode( '', $rows ) . "</table>\n";
51 -echo "<!-- Request time: " . ( microtime( true ) - $time ) . " -->\n";
 50+echo implode( '', $rows );
 51+echo " </table>\n";
 52+echo " <!-- Request time: " . ( microtime( true ) - $time ) . " -->\n";
5253 if ( $retval ) {
53 - echo "<p>Error: " . htmlspecialchars( $error ) . "</p>\n";
 54+ echo " <p>Error: " . htmlspecialchars( $error ) . "</p>\n";
5455 }
 56+echo " </body>";
5557 echo "</html>\n";
5658
5759 function getUserInfo( $userName ) {

Status & tagging log