r100694 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100693‎ | r100694 | r100695 >
Date:13:16, 25 October 2011
Author:bawolff
Status:ok
Tags:
Comment:
(bug 29066) Decode character references in input to InputBox so they don't get double-encoded later by Xml::openElement.
Modified paths:
  • /trunk/extensions/InputBox/InputBox.classes.php (modified) (history)

Diff [purge]

Index: trunk/extensions/InputBox/InputBox.classes.php
@@ -510,7 +510,7 @@
511511 if ( strpos( $line, '=' ) === false )
512512 continue;
513513 list( $name, $value ) = explode( '=', $line, 2 );
514 - $values[ strtolower( trim( $name ) ) ] = trim( $value );
 514+ $values[ strtolower( trim( $name ) ) ] = Sanitizer::decodeCharReferences( trim( $value ) );
515515 }
516516
517517 // Build list of options, with local member names

Status & tagging log