r100632 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100631‎ | r100632 | r100633 >
Date:18:55, 24 October 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Review -> accept + tooltip
Modified paths:
  • /trunk/extensions/Translate/Translate.i18n.php (modified) (history)
  • /trunk/extensions/Translate/utils/MessageTable.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/MessageTable.php
@@ -224,6 +224,7 @@
225225 if ( in_array( $wgUser->getId(), $reviewers ) ) {
226226 $attribs['value'] = wfMessage( 'translate-messagereview-done' )->text();
227227 $attribs['disabled'] = 'disabled';
 228+ $attribs['title'] = wfMessage( 'translate-messagereview-doit' )->text();
228229 } elseif( $message->hasTag( 'fuzzy' ) ) {
229230 $attribs['value'] = wfMessage( 'translate-messagereview-submit' )->text();
230231 $attribs['disabled'] = 'disabled';
Index: trunk/extensions/Translate/Translate.i18n.php
@@ -368,20 +368,21 @@
369369 'translate-search-languagefilter' => 'Filter by language:',
370370 'translate-search-nofilter' => 'No filtering',
371371
372 - 'translate-messagereview-submit' => 'Review',
373 - 'translate-messagereview-progress' => 'Reviewing...',
374 - 'translate-messagereview-failure' => 'Reviewing... failed: $1',
375 - 'translate-messagereview-done' => 'Reviewed',
 372+ 'translate-messagereview-submit' => 'Accept',
 373+ 'translate-messagereview-progress' => 'Accepting...',
 374+ 'translate-messagereview-failure' => 'Accepting... failed: $1',
 375+ 'translate-messagereview-done' => 'Accepted',
376376 'translate-messagereview-apierror-invalidrevision' => 'Translation was not found',
377377 'translate-messagereview-apierror-unknownmessage' => 'Message was not found',
378378 'translate-messagereview-apierror-fuzzymessage' => 'Translation is marked as fuzzy',
379 - 'translate-messagereview-apierror-owntranslation' => 'You cannot review your own translations.',
380 - 'translate-messagereview-reviews' => 'Reviewed by {{PLURAL:$1|one user|$1 users}}',
381 - 'translate-messagereview-reviewswithyou' => 'Reviewed by {{PLURAL:$1|one user|$1 users}} including you',
382 - 'translate-messagereview-reviewsyou' => 'Reviewed by you',
 379+ 'translate-messagereview-apierror-owntranslation' => 'You cannot accept your own translations.',
 380+ 'translate-messagereview-reviews' => 'Accepted by {{PLURAL:$1|one user|$1 users}}',
 381+ 'translate-messagereview-reviewswithyou' => 'Accepted by {{PLURAL:$1|one user|$1 users}} including you',
 382+ 'translate-messagereview-reviewsyou' => 'Accepted by you',
383383
384 - 'translate-messagereview-no-fuzzy' => 'Fuzzy translations cannot be reviewed',
385 - 'translate-messagereview-no-own' => 'You cannot review your own translations',
 384+ 'translate-messagereview-no-fuzzy' => 'Fuzzy translations cannot be accepted.',
 385+ 'translate-messagereview-no-own' => 'You cannot accept your own translations.',
 386+ 'translate-messagereview-doit' => 'Accept this translation as a correct translation.',
386387
387388 // Damn the 16 character limit for user group names!
388389 'group-translate-proofr' => 'Translation reviewers',
@@ -611,6 +612,7 @@
612613 'translate-messagereview-reviewsyou' => 'Status message in Special:Translate in review mode',
613614 'translate-messagereview-no-fuzzy' => 'Tooltip for disabled review button',
614615 'translate-messagereview-no-own' => 'Tooltip for disabled review button',
 616+ 'translate-messagereview-doit' => 'Tooltip for review button',
615617 );
616618
617619 /** Faeag Rotuma (Faeag Rotuma)

Status & tagging log