r100587 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100586‎ | r100587 | r100588 >
Date:09:07, 24 October 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
setCaller exists since 1.17 so no need to check whether it exists, spotted by Amir
Modified paths:
  • /trunk/extensions/Translate/utils/MessageTable.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/MessageTable.php
@@ -259,9 +259,7 @@
260260
261261 protected function doLinkBatch() {
262262 $batch = new LinkBatch();
263 - if ( method_exists( $batch, 'setCaller' ) ) {
264 - $batch->setCaller( __METHOD__ );
265 - }
 263+ $batch->setCaller( __METHOD__ );
266264 $ns = $this->group->getNamespace();
267265 foreach ( $this->collection->keys() as $key ) {
268266 $batch->add( $ns, $key );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100345Translation review interface...nikerabbit13:58, 20 October 2011

Status & tagging log