r100585 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100584‎ | r100585 | r100586 >
Date:08:51, 24 October 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Better error messages and corrected param description
Modified paths:
  • /trunk/extensions/Translate/api/ApiTranslationReview.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/api/ApiTranslationReview.php
@@ -24,13 +24,13 @@
2525
2626 $revision = Revision::newFromId( $params['revision'] );
2727 if ( !$revision ) {
28 - $this->dieUsage( 'You made me sad :(', 'invalidrevision' );
 28+ $this->dieUsage( 'Invalid revision', 'invalidrevision' );
2929 }
3030
3131 $title = $revision->getTitle();
3232 $handle = new MessageHandle( $title );
3333 if ( !$handle->isValid() ) {
34 - $this->dieUsage( 'You made me confused :X', 'unknownmessage' );
 34+ $this->dieUsage( 'Unknown message', 'unknownmessage' );
3535 }
3636
3737 if ( $handle->isFuzzy() ) {
@@ -87,7 +87,7 @@
8888 public function getParamDescription() {
8989 return array(
9090 'revision' => 'The revision number to review',
91 - 'token' => 'A token previously acquired with prop=token&intoken=translationreview',
 91+ 'token' => 'A token previously acquired with action=query&prop=info&intoken=translationreview',
9292 );
9393 }
9494

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100243Api module for marking translations as reviewed....nikerabbit17:35, 19 October 2011

Status & tagging log