r100530 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100529‎ | r100530 | r100531 >
Date:08:17, 23 October 2011
Author:hartman
Status:ok
Tags:
Comment:
Use attr() instead of this.href, to make sure that we don't absolutify the URI.

Fixes bug 31899
Modified paths:
  • /trunk/phase3/resources/mediawiki.special/mediawiki.special.search.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.special/mediawiki.special.search.js
@@ -22,7 +22,7 @@
2323 $('#searchText, #powerSearchText').change(function() {
2424 var searchterm = $(this).val();
2525 headerLinks.each( function() {
26 - var parts = this.href.split( 'search=' );
 26+ var parts = $(this).attr('href').split( 'search=' );
2727 var lastpart = '';
2828 var prefix = 'search=';
2929 if( parts.length > 1 && parts[1].indexOf('&') >= 0 ) {
@@ -34,4 +34,4 @@
3535 });
3636 }).trigger('change');
3737
38 -} );
\ No newline at end of file
 38+} );

Status & tagging log