r100528 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100527‎ | r100528 | r100529 >
Date:08:12, 23 October 2011
Author:petrb
Status:deferred
Tags:
Comment:
Improved layout and added some description for config
Modified paths:
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php (modified) (history)
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php
@@ -24,7 +24,7 @@
2525 {
2626 global $wgOnlineStatusBarModes, $wgOnlineStatusBarIcon, $wgOnlineStatusBarColor;
2727 $color= $wgOnlineStatusBarColor[$mode];
28 - return '<div style="border: 0px solid black; background: transparent; float: right; position: relative; top:-3px; padding: 5px"><p><b>' . $text . ': <span style="color: ' . $color . '; font:bold;"><img alt="Ledorange.svg" src="' . $wgOnlineStatusBarIcon[$mode] . '" width="20" height="20" />' . $wgOnlineStatusBarModes[$mode] . '</span></b></p></div>';
 28+ return '<div style="border: 0px solid black; background: transparent; float: right; position: relative; top:-52px; padding: 5px"><p><b>' . $text . ': <span style="color: ' . $color . '; font:bold;"><img alt=" . $text . " - " . $mode ." src="' . $wgOnlineStatusBarIcon[$mode] . '" width="20" height="20" />' . $wgOnlineStatusBarModes[$mode] . '</span></b></p></div>';
2929 }
3030
3131 static function UpdateDb()
@@ -77,7 +77,7 @@
7878 {
7979 // fix me
8080 global $wgScriptPath;
81 - $url = $wgScriptPath . "/extensions" . "$name";
 81+ $url = $wgScriptPath . "/extensions/OnlineStatusBar" . "$name";
8282 return $url;
8383 }
8484
Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.php
@@ -29,6 +29,7 @@
3030 $wgAutoloadClasses['OnlineStatusBar'] = "$dir/OnlineStatusBar.body.php";
3131
3232 // Configuration
 33+// Those values can be overriden in LocalSettings, do not change it here
3334 $wgOnlineStatusBarModes = array (
3435 'online' => "On-line",
3536 'busy' => "Busy",
@@ -37,11 +38,11 @@
3839 'offline' => "Offline",
3940 );
4041 $wgOnlineStatusBarIcon = array (
41 - 'online' => OnlineStatusBar::GetFileUrl( "/OnlineStatusBar/20px-Ledgreen.svg.png" ),
42 - 'busy' => OnlineStatusBar::GetFileUrl( "/OnlineStatusBar/20px-Ledorange.svg.png" ),
43 - 'away' => OnlineStatusBar::GetFileUrl( "/OnlineStatusBar/20px-Ledorange.svg.png" ),
44 - 'hidden' => OnlineStatusBar::GetFileUrl( "/OnlineStatusBar/20px-Nuvola_apps_krec.svg.png"),
45 - 'offline' => OnlineStatusBar::GetFileUrl( "/OnlineStatusBar/20px-Nuvola_apps_krec.svg.png"),
 42+ 'online' => OnlineStatusBar::GetFileUrl( "/20px-Ledgreen.svg.png" ),
 43+ 'busy' => OnlineStatusBar::GetFileUrl( "/20px-Ledorange.svg.png" ),
 44+ 'away' => OnlineStatusBar::GetFileUrl( "/20px-Ledorange.svg.png" ),
 45+ 'hidden' => OnlineStatusBar::GetFileUrl( "/20px-Nuvola_apps_krec.svg.png"),
 46+ 'offline' => OnlineStatusBar::GetFileUrl( "/20px-Nuvola_apps_krec.svg.png"),
4647 );
4748 $wgOnlineStatusBarColor = array (
4849 'online' => "green",
@@ -51,10 +52,15 @@
5253 'offline' => "red",
5354 );
5455
 56+//default for online
5557 $wgOnlineStatusBarDefaultOnline = "online";
 58+//default for offline
5659 $wgOnlineStatusBarDefaultOffline = "offline";
 60+//name of table in db
5761 $wgOnlineStatusBarTable = "online_status";
 62+//if new users have this feature enabled by default (experimental)
5863 $wgOnlineStatusBarDefaultEnabled = false;
 64+//how long to wait until user is considered as offline
5965 $wgOnlineStatusBar_LogoutTime = 3600;
6066
6167 $wgHooks['LoadExtensionSchemaUpdates'][] = 'wfOnlineStatusBar_CkSchema';

Status & tagging log