r100493 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100492‎ | r100493 | r100494 >
Date:02:43, 22 October 2011
Author:reedy
Status:ok
Tags:
Comment:
MFT r99653
Modified paths:
  • /branches/REL1_18 (modified) (history)
  • /branches/REL1_18/extensions (modified) (history)
  • /branches/REL1_18/extensions/UploadWizard (modified) (history)
  • /branches/REL1_18/extensions/UploadWizard/resources/mw.fileApi.js (modified) (history)
  • /branches/REL1_18/phase3 (modified) (history)
  • /branches/REL1_18/phase3/resources/mediawiki.special/mediawiki.special.upload.js (modified) (history)

Diff [purge]

Index: branches/REL1_18/extensions/UploadWizard/resources/mw.fileApi.js
@@ -16,12 +16,13 @@
1717 * Also excludes files over 10M to avoid going insane on memory usage.
1818 *
1919 * @todo is there a way we can ask the browser what's supported in <img>s?
 20+ * @todo put SVG back after working around Firefox 7 bug <https://bugzilla.wikimedia.org/show_bug.cgi?id=31643>
2021 *
2122 * @param {File} file
2223 * @return boolean
2324 */
2425 isPreviewableFile: function( file ) {
25 - var known = [ 'image/png', 'image/gif', 'image/jpeg', 'image/svg+xml'],
 26+ var known = [ 'image/png', 'image/gif', 'image/jpeg'],
2627 tooHuge = 10 * 1024 * 1024;
2728 return ( $.inArray( file.type, known ) !== -1 ) && file.size > 0 && file.size < tooHuge;
2829 }
Property changes on: branches/REL1_18/extensions/UploadWizard
___________________________________________________________________
Modified: svn:mergeinfo
2930 Merged /trunk/extensions/UploadWizard:r99653
Property changes on: branches/REL1_18/extensions
___________________________________________________________________
Modified: svn:mergeinfo
3031 Merged /trunk/extensions:r99653
Index: branches/REL1_18/phase3/resources/mediawiki.special/mediawiki.special.upload.js
@@ -19,12 +19,13 @@
2020 * Also excludes files over 10M to avoid going insane on memory usage.
2121 *
2222 * @todo is there a way we can ask the browser what's supported in <img>s?
 23+ * @todo put SVG back after working around Firefox 7 bug <https://bugzilla.wikimedia.org/show_bug.cgi?id=31643>
2324 *
2425 * @param {File} file
2526 * @return boolean
2627 */
2728 function fileIsPreviewable( file ) {
28 - var known = ['image/png', 'image/gif', 'image/jpeg', 'image/svg+xml'],
 29+ var known = ['image/png', 'image/gif', 'image/jpeg'],
2930 tooHuge = 10 * 1024 * 1024;
3031 return ( $.inArray( file.type, known ) !== -1 ) && file.size > 0 && file.size < tooHuge;
3132 }
Property changes on: branches/REL1_18/phase3
___________________________________________________________________
Modified: svn:mergeinfo
3233 Merged /trunk/phase3:r99653
Property changes on: branches/REL1_18
___________________________________________________________________
Added: svn:mergeinfo
3334 Merged /trunk:r99653

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99653Temporarily disable pre-upload SVG thumbnailing in Special:Upload and Special...brion22:46, 12 October 2011

Status & tagging log