r100477 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100476‎ | r100477 | r100478 >
Date:00:00, 22 October 2011
Author:laner
Status:deferred
Tags:ldap 
Comment:
Apparently order matters here. Odd.
Modified paths:
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LdapAuthentication/LdapAuthentication.php
@@ -1839,8 +1839,8 @@
18401840 function getLdapEscapedString( $string ) {
18411841 // Make the string LDAP compliant by escaping *, (, ) , \ & NUL
18421842 return str_replace(
1843 - array( "*", "(", ")", "\\", "\x00" ), // replace this
1844 - array( "\\2a", "\\28", "\\29", "\\5c", "\\00" ), // with this
 1843+ array( "\\", "(", ")", "*", "\x00" ), // replace this
 1844+ array( "\\5c", "\\28", "\\29", "\\2a", "\\00" ), // with this
18451845 $string // in this
18461846 );
18471847 }

Status & tagging log