r100472 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100471‎ | r100472 | r100473 >
Date:23:05, 21 October 2011
Author:khorn
Status:ok
Tags:
Comment:
Even more fixes for all the custom filters extras.
r100455, r100249, r100466
Modified paths:
  • /trunk/extensions/DonationInterface/extras/custom_filters/filters/referrer/referrer.body.php (modified) (history)
  • /trunk/extensions/DonationInterface/extras/custom_filters/filters/source/source.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/extras/custom_filters/filters/source/source.body.php
@@ -15,7 +15,7 @@
1616 public $cfo;
1717
1818 public function __construct( &$gateway_adapter, &$custom_filter_object ) {
19 - parent::__construct( &$gateway_adapter );
 19+ parent::__construct( $gateway_adapter );
2020 $this->cfo = & $custom_filter_object;
2121 }
2222
@@ -46,14 +46,14 @@
4747 return TRUE;
4848 }
4949
50 - static function onFilter( &$custom_filter_object ) {
 50+ static function onFilter( &$gateway_adapter, &$custom_filter_object ) {
5151 $gateway_adapter->debugarray[] = 'source onFilter hook!';
52 - return self::singleton( $custom_filter_object )->filter();
 52+ return self::singleton( $gateway_adapter, $custom_filter_object )->filter();
5353 }
5454
55 - static function singleton( &$custom_filter_object ) {
 55+ static function singleton( &$gateway_adapter, &$custom_filter_object ) {
5656 if ( !self::$instance ) {
57 - self::$instance = new self( $custom_filter_object );
 57+ self::$instance = new self( $gateway_adapter, $custom_filter_object );
5858 }
5959 return self::$instance;
6060 }
Index: trunk/extensions/DonationInterface/extras/custom_filters/filters/referrer/referrer.body.php
@@ -15,7 +15,7 @@
1616 public $cfo;
1717
1818 public function __construct( &$gateway_adapter, &$custom_filter_object ) {
19 - parent::__construct( &$gateway_adapter );
 19+ parent::__construct( $gateway_adapter );
2020 $this->cfo = & $custom_filter_object;
2121 }
2222
@@ -46,14 +46,14 @@
4747 return TRUE;
4848 }
4949
50 - static function onFilter( &$custom_filter_object ) {
 50+ static function onFilter( &$gateway_adapter, &$custom_filter_object ) {
5151 $gateway_adapter->debugarray[] = 'referrer onFilter hook!';
52 - return self::singleton( $custom_filter_object )->filter();
 52+ return self::singleton( $gateway_adapter, $custom_filter_object )->filter();
5353 }
5454
55 - static function singleton( &$custom_filter_object ) {
 55+ static function singleton( &$gateway_adapter, &$custom_filter_object ) {
5656 if ( !self::$instance ) {
57 - self::$instance = new self( $custom_filter_object );
 57+ self::$instance = new self( $gateway_adapter, $custom_filter_object );
5858 }
5959 return self::$instance;
6060 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r100484Debugging minfraud as a filter: Made sure we're passing in the contribution_t...khorn01:41, 22 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100249Merging the fundraising branch of DonationInterface back into trunk....khorn18:36, 19 October 2011
r100455Bug fix: None of the pre-process hooks will ever fire until we're checking th...khorn21:39, 21 October 2011
r100466Fixes for all the custom filters extras....khorn22:26, 21 October 2011

Status & tagging log