r100447 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100446‎ | r100447 | r100448 >
Date:20:24, 21 October 2011
Author:johnduhart
Status:ok
Tags:
Comment:
Followup r100396, use is_string instead of !is_array
Modified paths:
  • /trunk/phase3/includes/logging/LogFormatter.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/logging/LogFormatter.php
@@ -36,7 +36,7 @@
3737 $handler = $wgLogActionsHandlers[$wildcard];
3838 }
3939
40 - if ( $handler !== '' && !is_array( $handler ) && class_exists( $handler ) ) {
 40+ if ( $handler !== '' && is_string( $handler ) && class_exists( $handler ) ) {
4141 return new $handler( $entry );
4242 }
4343

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100396Bugfix to r96441, class_exists throws warnings when arrays are passed to itjohnduhart00:09, 21 October 2011

Status & tagging log