r100414 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100413‎ | r100414 | r100415 >
Date:06:39, 21 October 2011
Author:santhosh
Status:ok
Tags:
Comment:
Remove unnecessary addConfig. Follow up r100116
Modified paths:
  • /trunk/extensions/WebFonts/WebFonts.hooks.php (modified) (history)
  • /trunk/extensions/WebFonts/WebFonts.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WebFonts/WebFonts.hooks.php
@@ -17,20 +17,7 @@
1818
1919 return true; // Hooks must return value
2020 }
21 -
22 - public static function addConfig( &$vars ) {
23 - global $wgUser;
2421
25 - if ( $wgUser->getOption( 'webfontsDisable' ) ) {
26 - wfDebugLog( 'webfonts', 'User disabled WebFonts: ' , true );
27 - // User disabled WebFonts
28 - return true;
29 - }
30 -
31 -
32 - return true;
33 - }
34 -
3522 public static function addVariables( &$vars ) {
3623 global $wgWebFontsEnabledByDefault, $wgUser;
3724
Index: trunk/extensions/WebFonts/WebFonts.php
@@ -35,7 +35,6 @@
3636
3737 $wgHooks['BeforePageDisplay'][] = 'WebFontsHooks::addModules';
3838 $wgHooks['GetPreferences'][] = 'WebFontsHooks::addPreference';
39 -$wgHooks['ResourceLoaderGetConfigVars'][] = 'WebFontsHooks::addConfig';
4039 $wgHooks['MakeGlobalVariablesScript'][] = 'WebFontsHooks::addVariables';
4140
4241 $wgWebFontsEnabled = true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100116have a configuraiton parameter $wgEnableWebFontsDefault , when set false, don...santhosh15:22, 18 October 2011

Status & tagging log