r100341 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100340‎ | r100341 | r100342 >
Date:13:19, 20 October 2011
Author:hashar
Status:reverted
Tags:
Comment:
testrunner only needed for the qunit suite

Per Krinkle comment #8 on bug 30339, the testrunner only need
to be attached to the QUnit test suite.
Modified paths:
  • /branches/JSTesting/includes/resourceloader/ResourceLoader.php (modified) (history)

Diff [purge]

Index: branches/JSTesting/includes/resourceloader/ResourceLoader.php
@@ -208,16 +208,14 @@
209209 // Get core test suites
210210 $testModules = array();
211211 $testModules['qunit'] = include( "$IP/tests/qunit/QUnitTestResources.php" );
 212+ // Add the testrunner to the dependencies to make sure it's loaded first
 213+ $testModules['qunit']['mediawiki.tests.qunit.suites']['dependencies'][]
 214+ = 'mediawiki.tests.qunit.testrunner';
 215+
212216 // Allow extensions to add test suites
213217 wfRunHooks( 'ResourceLoaderTestModules', array( &$testModules, &$this ) );
214218
215219 foreach( $testModules as $id => $names ) {
216 -
217 - // Add the testrunner to the dependencies to make sure it's loaded first
218 - foreach( $names as $name ) {
219 - $testModules[$id][$name]['dependencies'][] = 'mediawiki.tests.qunit.testrunner';
220 - }
221 -
222220 // Register test modules
223221 $this->register( $testModules[$id] );
224222

Follow-up revisions

RevisionCommit summaryAuthorDate
r100370[JSTesting] Reset branch. In preparation of re-branching....krinkle20:40, 20 October 2011
r100374[JSTesting] Re-branch from trunk....krinkle21:02, 20 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100339creating branch for JavaScript testing...hashar12:46, 20 October 2011
r100340(bug 30339) SpecialPage for running JS tests...hashar12:53, 20 October 2011

Status & tagging log