r100316 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100315‎ | r100316 | r100317 >
Date:01:24, 20 October 2011
Author:jeroendedauw
Status:ok
Tags:
Comment:
minor fixes
Modified paths:
  • /trunk/extensions/Contest/Contest.php (modified) (history)
  • /trunk/extensions/Contest/includes/ContestReminderJob.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Contest/Contest.php
@@ -101,6 +101,9 @@
102102 $wgAPIListModules['contestcomments'] = 'ApiQueryContestComments';
103103 $wgAPIListModules['contests'] = 'ApiQueryContests';
104104
 105+// Jobs
 106+$wgJobClasses['ContestReminderJob'] = 'ContestReminderJob';
 107+
105108 // Hooks
106109 $wgHooks['LoadExtensionSchemaUpdates'][] = 'ContestHooks::onSchemaUpdate';
107110 $wgHooks['UnitTestsList'][] = 'ContestHooks::registerUnitTests';
Index: trunk/extensions/Contest/includes/ContestReminderJob.php
@@ -22,8 +22,8 @@
2323 * * contest, Contest, required
2424 */
2525 public function __construct( Title $title, array $params ) {
26 - parent::__construct( 'ContestReminderJob', $title, $params );
27 - $this->params['emailText'] = ContestUtils::getParsedArticleContent( $this->params['reminder_email'] );
 26+ parent::__construct( __CLASS__, $title, $params );
 27+ $this->params['emailText'] = ContestUtils::getParsedArticleContent( $this->params['contest']->getField( 'reminder_email' ) );
2828 $this->params['daysLeft'] = $this->params['contest']->getDaysLeft();
2929 }
3030

Follow-up revisions

RevisionCommit summaryAuthorDate
r1003171.18wmf1 MFT r100316reedy01:27, 20 October 2011
r1003191.18wmf1 MFT r100314, r100316reedy01:31, 20 October 2011

Status & tagging log