r100304 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100303‎ | r100304 | r100305 >
Date:00:41, 20 October 2011
Author:aaron
Status:ok
Tags:
Comment:
FU r100300, r100286:
* Updated link batch code in MergeHistory
* Marked some Revision functions explicitly public
Modified paths:
  • /trunk/phase3/includes/Revision.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialMergeHistory.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Revision.php
@@ -305,7 +305,7 @@
306306 * Return the list of text fields that should be selected to read the
307307 * revision text
308308 */
309 - static function selectTextFields() {
 309+ public static function selectTextFields() {
310310 return array(
311311 'old_text',
312312 'old_flags'
@@ -315,7 +315,7 @@
316316 /**
317317 * Return the list of page fields that should be selected from page table
318318 */
319 - static function selectPageFields() {
 319+ public static function selectPageFields() {
320320 return array(
321321 'page_namespace',
322322 'page_title',
@@ -326,7 +326,7 @@
327327 /**
328328 * Return the list of user fields that should be selected from user table
329329 */
330 - static function selectUserFields() {
 330+ public static function selectUserFields() {
331331 return array( 'COALESCE(user_name,rev_user_text) AS rev_user_name' );
332332 }
333333
Index: trunk/phase3/includes/specials/SpecialMergeHistory.php
@@ -452,8 +452,8 @@
453453 # Give some pointers to make (last) links
454454 $this->mForm->prevId = array();
455455 foreach ( $this->mResult as $row ) {
456 - $batch->addObj( Title::makeTitleSafe( NS_USER, $row->rev_user_text ) );
457 - $batch->addObj( Title::makeTitleSafe( NS_USER_TALK, $row->rev_user_text ) );
 456+ $batch->addObj( Title::makeTitleSafe( NS_USER, $row->rev_user_name ) );
 457+ $batch->addObj( Title::makeTitleSafe( NS_USER_TALK, $row->rev_user_name ) );
458458
459459 $rev_id = isset( $rev_id ) ? $rev_id : $row->rev_id;
460460 if( $rev_id > $row->rev_id ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100286* Tweaked Revision class to handle loading the current user name instead of r...aaron22:25, 19 October 2011
r100300JOIN to get user_name in Contributions, HistoryPage, RevisionList, RevisionDe...aaron00:04, 20 October 2011

Status & tagging log