r100266 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100265‎ | r100266 | r100267 >
Date:20:01, 19 October 2011
Author:mah
Status:ok
Tags:
Comment:
Revert r100262 — wasn't the right place for it and other problems,
like broken parser tests.

Please read [[Manual:Pre-commit checklist]] before committing.
Modified paths:
  • /trunk/phase3/includes/parser/StripState.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/StripState.php
@@ -107,9 +107,6 @@
108108 if ( isset( $this->data[$this->tempType][$m[1]] ) ) {
109109 return $this->data[$this->tempType][$m[1]];
110110 } else {
111 - if( preg_match( $this->regex, $m[0] ) ) {
112 - return "<strong class='error'>".htmlspecialchars( wfMsg( "stripstate-error" ) )."</strong>";
113 - }
114111 return $m[0];
115112 }
116113 }
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -4471,7 +4471,6 @@
44724472 # Core parser functions
44734473 'unknown_extension_tag' => 'Unknown extension tag "$1"',
44744474 'duplicate-defaultsort' => '\'\'\'Warning:\'\'\' Default sort key "$2" overrides earlier default sort key "$1".',
4475 -'stripstate-error' => 'unstripCallback called with strip markers still intact. Please fix your markup.',
44764475
44774476 # Special:Version
44784477 'version' => 'Version',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100262Give a clear error message instead of un-intelligible UNIQ.*QINU...mah19:34, 19 October 2011

Status & tagging log