r100263 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100262‎ | r100263 | r100264 >
Date:19:35, 19 October 2011
Author:aaron
Status:ok
Tags:
Comment:
Simplified query a bit given PK change
Modified paths:
  • /trunk/extensions/FlaggedRevs/presentation/FlaggedRevsUI.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/FlaggedRevsUI.hooks.php
@@ -302,8 +302,7 @@
303303 $queryInfo['fields'][] = 'fr_quality';
304304 $queryInfo['fields'][] = 'fr_user';
305305 $queryInfo['fields'][] = 'fr_flags';
306 - $queryInfo['join_conds']['flaggedrevs'] = array( 'LEFT JOIN',
307 - "fr_page_id = rev_page AND fr_rev_id = rev_id" );
 306+ $queryInfo['join_conds']['flaggedrevs'] = array( 'LEFT JOIN', "fr_rev_id = rev_id" );
308307 # Find reviewer name. Sanity check that no extensions added a `user` query.
309308 if ( !in_array( 'user', $queryInfo['tables'] ) ) {
310309 $queryInfo['tables'][] = 'user';
@@ -348,8 +347,7 @@
349348 # Highlight flaggedrevs
350349 $queryInfo['tables'][] = 'flaggedrevs';
351350 $queryInfo['fields'][] = 'fr_quality';
352 - $queryInfo['join_conds']['flaggedrevs'] = array( 'LEFT JOIN',
353 - "fr_page_id = rev_page AND fr_rev_id = rev_id" );
 351+ $queryInfo['join_conds']['flaggedrevs'] = array( 'LEFT JOIN', "fr_rev_id = rev_id" );
354352 # Highlight unchecked content
355353 $queryInfo['tables'][] = 'flaggedpages';
356354 $queryInfo['fields'][] = 'fp_stable';

Status & tagging log