r100257 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100256‎ | r100257 | r100258 >
Date:19:03, 19 October 2011
Author:reedy
Status:old
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/Contest (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/Contest/resources/jquery.contestChallenges.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/Contest/resources/jquery.contestChallenges.js
@@ -36,7 +36,6 @@
3737 .fadeOut( 'fast' );
3838 } );
3939 e.stopPropagation();
40 - return false;
4140 }
4241 } )
4342 .append(
@@ -55,8 +54,9 @@
5655 )
5756 .append(
5857 $( '<div class="mw-codechallenge-popup"><div>' )
59 - .click( function() {
60 - return false;
 58+ .click( function( e ) {
 59+ e.stopPropogation();
 60+ e.preventDefault();
6161 } )
6262 .append( '<div class="mw-codechallenge-popup-callout"></div>' )
6363 .append( challenge.text )
Property changes on: branches/wmf/1.18wmf1/extensions/Contest
___________________________________________________________________
Modified: svn:mergeinfo
6464 Merged /trunk/extensions/Contest:r100252,100255

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100252Fix inability to click on links in popup boxes per Krinklereedy18:44, 19 October 2011

Status & tagging log