r100207 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100206‎ | r100207 | r100208 >
Date:03:11, 19 October 2011
Author:jpostlethwaite
Status:ok
Tags:fundraising 
Comment:
See r98470 - Cleaning up form code and reordering function calls.
Modified paths:
  • /branches/fundraising/extensions/DonationInterface/gateway_forms/TwoStepAmount.php (modified) (history)

Diff [purge]

Index: branches/fundraising/extensions/DonationInterface/gateway_forms/TwoStepAmount.php
@@ -28,12 +28,12 @@
2929
3030 $form_data['transaction_type'] = 'BANK_TRANSFER';
3131 $form_data['process'] = 'BANK_TRANSFER';
32 - parent::__construct( $form_data, $form_errors, $gateway );
3332
3433 // we only want to load this JS if the form is being rendered
3534 $this->loadValidateJs(); // validation JS
3635
3736 $this->loadPlaceholders();
 37+ parent::__construct( $form_data, $form_errors, $gateway );
3838 }
3939
4040 public function loadPlaceholders() {
@@ -152,8 +152,6 @@
153153 $form .= $this->generateFormSubmit();
154154 $form .= Xml::closeElement( 'div' ); // close div#left-column
155155
156 - //$form .= Xml::openElement( 'div', array( 'id' => 'right-column', 'class' => 'payflow-cc-form-section' ) );
157 -
158156 return $form;
159157 }
160158
@@ -179,9 +177,6 @@
180178 $form .= Html::hidden( $field, $value );
181179 }
182180
183 - $value = 'BANK_TRANSFER';
184 - //$form .= Html::hidden( $field, $value );
185 - //$form .= Xml::closeElement( 'div' ); // close div#right-column
186181 $form .= Xml::closeElement( 'form' );
187182 $form .= Xml::closeElement( 'div' ); // close div#mw-creditcard-form
188183 $form .= $this->generateDonationFooter();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98470Added a form for BANK_TRANSFER.jpostlethwaite22:10, 29 September 2011

Status & tagging log