r10018 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r10017‎ | r10018 | r10019 >
Date:18:48, 8 July 2005
Author:avar
Status:old
Tags:
Comment:
* Fixed a missing typecast in Language::dateFormat() that would cause some
interesting errors with signitures.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
@@ -545,6 +545,8 @@
546546 * (bug 2721) New language file for Vietnamese with the Vietnamese number notation
547547 * (bug 2749)   would appear as a literal in image galleries for Cs, Fr, Fur, Pl and Sv
548548 * (bug 787) external links being rendered when they only have one slash
 549+* Fixed a missing typecast in Language::dateFormat() that would cause some
 550+ interesting errors with signitures.
549551
550552 === Caveats ===
551553
Index: trunk/phase3/languages/Language.php
@@ -2405,7 +2405,7 @@
24062406
24072407 if ( !$wgUser->isLoggedIn() || $format === false ) {
24082408 $options = $this->getDefaultUserOptions();
2409 - return $options['date'];
 2409+ return (string)$options['date'];
24102410 } else {
24112411 return $wgUser->getOption( 'date' );
24122412 }

Status & tagging log