r100171 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100170‎ | r100171 | r100172 >
Date:22:01, 18 October 2011
Author:reedy
Status:ok
Tags:
Comment:
Comment out another userright line

Documentation
Modified paths:
  • /trunk/extensions/Contest/Contest.php (modified) (history)
  • /trunk/extensions/Contest/includes/ContestantPager.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Contest/Contest.php
@@ -126,7 +126,7 @@
127127 # Users that can be contest participants.
128128 $wgGroupPermissions['*' ]['contestparticipant'] = false;
129129 $wgGroupPermissions['user' ]['contestparticipant'] = true;
130 -$wgGroupPermissions['autoconfirmed']['contestparticipant'] = true;
 130+//$wgGroupPermissions['autoconfirmed']['contestparticipant'] = true;
131131 //$wgGroupPermissions['bot' ]['contestparticipant'] = false;
132132 $wgGroupPermissions['sysop' ]['contestparticipant'] = true;
133133 $wgGroupPermissions['contestparticipant']['contestparticipant'] = true;
Index: trunk/extensions/Contest/includes/ContestantPager.php
@@ -139,6 +139,10 @@
140140 return $headers;
141141 }
142142
 143+ /**
 144+ * @param $row
 145+ * @return string
 146+ */
143147 function formatRow( $row ) {
144148 $this->mCurrentRow = $row; # In case formatValue etc need to know
145149 $s = Xml::openElement( 'tr', $this->getRowAttrs($row) );
@@ -157,6 +161,10 @@
158162 return $s;
159163 }
160164
 165+ /**
 166+ * @param $row
 167+ * @return array
 168+ */
161169 function getRowAttrs( $row ) {
162170 return array_merge(
163171 parent::getRowAttrs( $row ),
@@ -164,10 +172,19 @@
165173 );
166174 }
167175
 176+ /**
 177+ * @param $row
 178+ * @return string
 179+ */
168180 function getRowClass( $row ) {
169181 return 'contestant-row';
170182 }
171183
 184+ /**
 185+ * @param $name
 186+ * @param $value
 187+ * @return string
 188+ */
172189 public function formatValue( $name, $value ) {
173190 switch ( $name ) {
174191 case 'contestant_id':

Status & tagging log