r100155 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100154‎ | r100155 | r100156 >
Date:20:28, 18 October 2011
Author:raindrift
Status:ok
Tags:
Comment:
fixed weird scrolling behavior for multi-file selection
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.UploadWizard.js
@@ -354,7 +354,11 @@
355355 var _this = this;
356356
357357 // scroll to the top of the page (the current step might have been very long, vertically)
358 - $j( 'html, body' ).animate( { scrollTop: 0 }, 'slow' );
 358+ if ( selectedStepName !== 'file' ) {
 359+ // this is the wrong behavior when selecting files (hides interface), so skip it.
 360+ // also, it breaks scrolling when selecting multiple files at once.
 361+ $j( 'html, body' ).animate( { scrollTop: 0 }, 'slow' );
 362+ }
359363
360364 $j.each( _this.stepNames, function(i, stepName) {
361365

Follow-up revisions

RevisionCommit summaryAuthorDate
r100177more correct fix for the multi-file scrolling -- the problem was that it call...neilk22:29, 18 October 2011

Status & tagging log