r100095 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100094‎ | r100095 | r100096 >
Date:22:56, 17 October 2011
Author:kaldari
Status:ok
Tags:fundraising 
Comment:
changing from double quotes to single quotes, leaving a note for myself
Modified paths:
  • /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/html/lightbox1.html (modified) (history)
  • /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/js/lightbox1.js (modified) (history)

Diff [purge]

Index: branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/html/lightbox1.html
@@ -3,8 +3,8 @@
44 mw.loader.load( 'jquery.ui.button' );
55 mw.loader.load( 'jquery.ui.dialog' );
66 var extensionPath = mw.config.get( 'wgServer' ) + mw.config.get( 'wgScriptPath' ) + '/extensions/DonationInterface';
7 -mw.loader.load( extensionPath + '/payflowpro_gateway/forms/js/lightbox1.js', "text/javascript" );
8 -mw.loader.load( extensionPath + '/payflowpro_gateway/forms/css/lightbox1.css', "text/css" );
 7+mw.loader.load( extensionPath + '/payflowpro_gateway/forms/js/lightbox1.js', 'text/javascript' );
 8+mw.loader.load( extensionPath + '/payflowpro_gateway/forms/css/lightbox1.css', 'text/css' );
99 </script>
1010
1111 <div class="ltr">
Index: branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/js/lightbox1.js
@@ -129,6 +129,7 @@
130130 )
131131
132132 /* Submit the form */
 133+ /* TODO: Replace this with AJAX request */
133134 document.donationForm.action = $( "input[name='action']" ).val();
134135 document.donationForm.submit();
135136 }

Status & tagging log