r100089 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100088‎ | r100089 | r100090 >
Date:21:12, 17 October 2011
Author:neilk
Status:ok
Tags:
Comment:
default value for enableMultiFileSelect, removed a line of redundant code
Modified paths:
  • /trunk/extensions/UploadWizard/UploadWizard.config.php (modified) (history)
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizardUploadInterface.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/UploadWizard.config.php
@@ -395,4 +395,7 @@
396396 // Wiki page for reporting issues with the blacklist
397397 'blacklistIssuesPage' => '',
398398
 399+ // Whether multi-file select is enabled -- this is temporary, just waiting for backend code r93270 to be reviewed
 400+ 'enableMultiFileSelect' => false
 401+
399402 );
Index: trunk/extensions/UploadWizard/resources/mw.UploadWizardUploadInterface.js
@@ -16,10 +16,9 @@
1717 _this.div = $j('<div class="mwe-upwiz-file"></div>').get(0);
1818 _this.isFilled = false;
1919
20 - if( mw.UploadWizard.config[ 'enableMultiFileSelect' ] ) {
21 - _this.$fileInputCtrl = $j('<input size="1" class="mwe-upwiz-file-input" name="file" type="file" multiple="1"/>');
22 - } else {
23 - _this.$fileInputCtrl = $j('<input size="1" class="mwe-upwiz-file-input" name="file" type="file"/>');
 20+ _this.$fileInputCtrl = $j( '<input size="1" class="mwe-upwiz-file-input" name="file" type="file"/>' );
 21+ if( mw.UploadWizard.config['enableMultiFileSelect'] ) {
 22+ _this.$fileInputCtrl.attr( 'multiple', '1' );
2423 }
2524
2625 _this.initFileInputCtrl();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99799added config option for muti-file select so we can deploy with it off, as 1.1...raindrift20:07, 14 October 2011

Status & tagging log