r100042 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100041‎ | r100042 | r100043 >
Date:15:57, 17 October 2011
Author:hashar
Status:ok
Tags:
Comment:
add useful comments about portlet ids

comments comes from r95571 commit log by Krinkle
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js
@@ -142,6 +142,13 @@
143143 strictEqual( mw.util.$content.length, 1, 'mw.util.$content must have length of 1' );
144144 });
145145
 146+
 147+/**
 148+ * Portlet names are prefixed with 'p-test' to avoid conflict with core
 149+ * when running the test suite under a wiki page.
 150+ * Previously, test elements where invisible to the selector since only
 151+ * one element can have a given id.
 152+ */
146153 test( 'addPortletLink', function() {
147154 expect(7);
148155

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95571mediawiki.util.test: Change portlet name to not conflict with core...krinkle19:46, 26 August 2011

Status & tagging log