r100018 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r100017‎ | r100018 | r100019 >
Date:09:46, 17 October 2011
Author:hashar
Status:ok
Tags:
Comment:
adding note to code snippet

This small comment will avoid us using pathinfo() again and reimplement
bug 30219.
follow up r94171
Modified paths:
  • /trunk/phase3/includes/templates/NoLocalSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/templates/NoLocalSettings.php
——@@ -10,6 +10,7 @@
1111 $wgVersion = 'VERSION';
1212 }
1313
 14+# bug 30219 : can not use pathinfo() on URLs since slashes do not match
1415 $matches = array();
1516 $ext = 'php';
1617 $path = '/';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94171(bug 30219) NoLocalSettings.php broken on Windows servers. Per Tim on r70711,...demon17:28, 10 August 2011

Status & tagging log